From 3dae779724234124ef11b598aa46e5c25ef64c70 Mon Sep 17 00:00:00 2001 From: Kacper Date: Thu, 10 Sep 2026 09:24:15 +0200 Subject: [PATCH] test: stop OuTreeServiceTest hitting a real LDAP server MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit it_limits_tree_to_default_user_and_computer_ous only mocked OrganizationalUnit::query(); attachCounts() then called the real User/Computer query via countObjectsInOu(), which threw "Can't contact LDAP server" on any checkout whose .env points LDAP_HOSTS at an unreachable DC (i.e. every CI run since v1.0.0). Stub countObjectsInOu() on a partial mock, like the sibling test already does — the test only asserts tree shape, not counts. Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01JKT9p3bfP8RZesExdYCS52 --- tests/Unit/OuTreeServiceTest.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/Unit/OuTreeServiceTest.php b/tests/Unit/OuTreeServiceTest.php index a8933ea..90e8106 100644 --- a/tests/Unit/OuTreeServiceTest.php +++ b/tests/Unit/OuTreeServiceTest.php @@ -114,7 +114,11 @@ class OuTreeServiceTest extends TestCase Mockery::mock('alias:\LdapRecord\Models\ActiveDirectory\OrganizationalUnit') ->shouldReceive('query')->twice()->andReturn($query); - $service = new OuTreeService; + // Ten test sprawdza wyłącznie kształt drzewa (ograniczenie do rootów + + // zagnieżdżenie), nie liczniki - a countObjectsInOu() odpytałoby realny + // LDAP. Podstawiamy 0. + $service = Mockery::mock(OuTreeService::class)->makePartial()->shouldAllowMockingProtectedMethods(); + $service->shouldReceive('countObjectsInOu')->andReturn(0); $userTree = $service->tree('users'); $computerTree = $service->tree('computers');